chore(l1): memory enhancement - no transactional rocksdb + no cache #4839
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Copilot <[email protected]>
This reverts commit 7c5315c.
Lines of code reportTotal lines added: Detailed view |
|
Here is a table comparision of 2 runs of this PR vs main: Node Memory (RSS) & Host in images
This is an enhancement of ~40~50% in the Mean and ~30~40% in peaks, it appears to be a noticeable regression related to time ~50% slower, but we need more test to validate it wasn't an issue of the particular runs (variance for the runs is still high) |
rodrigo-o
changed the title
rodrigo-o
changed the title
…space to avoid unneded diff
|
Closed in favor of #4853 |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 17, 2025
…plicit configured cache (#4853) **Motivation** This PR reduce memory by 40~50% **Description** This PR sits is basically #4839 but instead of starting from #4821 it starts from main, and after different testing scenarios we came up with this cut in memory: - reverts #4599 - removes the rocksdb cache explicit setup The caveat is that it appears to be 50% slower, we need to make specific measures to validate the results seen in #4839 --------- Co-authored-by: Mario Rugiero <[email protected]> Co-authored-by: Javier Chatruc <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This PR reduce memory by 40~50%
Description
This PR sits on top of #4821 and after different testing scenarios we came up with this cut in memory:
The caveat is that it appears to be 50% slower, we need to double check it.